Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic Prerelease Functionality #34

Merged
merged 9 commits into from
Feb 5, 2024
Merged

Generic Prerelease Functionality #34

merged 9 commits into from
Feb 5, 2024

Conversation

CodeGat
Copy link
Member

@CodeGat CodeGat commented Feb 1, 2024 •
edited
Loading

In this PR:

  • Updated create-deployment-spack.yml to allow for installations of spack outside of vk83
  • Updated deploy-*.yml to work with a type and version input, where:
    • type is (for now) either release or prerelease.
    • version is the version that the model will be tagged with once deployed (ex: 2024.01.1 or 2024.02.1-1

Closes #32

@CodeGat CodeGat added type:feature New feature type:enhancement Improvements to existing features priority:high labels Feb 1, 2024
@CodeGat CodeGat self-assigned this Feb 1, 2024
@CodeGat CodeGat marked this pull request as ready for review February 1, 2024 23:25
@CodeGat CodeGat marked this pull request as draft February 1, 2024 23:41
@CodeGat CodeGat marked this pull request as ready for review February 2, 2024 00:25
aidanheerdegen
aidanheerdegen previously approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for you merge as-is, but made a few comments.

CodeGat
CodeGat commented Feb 5, 2024
View reviewed changes
Copy link
Member Author

@CodeGat CodeGat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the review!

aidanheerdegen
aidanheerdegen previously approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't believe I've suggested you make another change, but I have and I'm willing to rubber-stamp after this.

aidanheerdegen
aidanheerdegen approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeGat CodeGat merged commit 2df1b30 into main Feb 5, 2024
2 checks passed
@CodeGat CodeGat deleted the 32-prerelease branch February 5, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidanheerdegen aidanheerdegen aidanheerdegen approved these changes

Assignees

@CodeGat CodeGat

Labels
priority:high type:enhancement Improvements to existing features type:feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow Prerelease for Deployment
2 participants
@CodeGat @aidanheerdegen